refactor: extract shared S3 client config into global config block#231
Merged
alecthomas merged 1 commit intomainfrom Mar 29, 2026
Merged
refactor: extract shared S3 client config into global config block#231alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
Pull S3 connection config (endpoint, region, SSL settings) and minio client construction out of the S3 cache backend into a new s3client package, following the same pattern as gitclone.Config/ManagerProvider. - Add internal/s3client with Config, ClientProvider, and NewClient - Config is an optional HCL block in GlobalConfig - ClientProvider lazily constructs a singleton *minio.Client - NewClient verifies connectivity via ListBuckets up front - S3Config retains only cache-specific fields (bucket, TTL, upload tuning) - RegisterS3/NewS3 accept a ClientProvider parameter - Move minitest to s3client/s3clienttest with deterministic per-package bucket names derived from runtime caller inspection, cleaning stale objects up front and via t.Cleanup Co-authored-by: Claude Code <noreply@anthropic.com>
alecthomas
added a commit
that referenced
this pull request
Mar 30, 2026
) Pull S3 connection config (endpoint, region, SSL settings) and minio client construction out of the S3 cache backend into a new s3client package, following the same pattern as gitclone.Config/ManagerProvider. - Add internal/s3client with Config, ClientProvider, and NewClient - Config is an optional HCL block in GlobalConfig - ClientProvider lazily constructs a singleton *minio.Client - NewClient verifies connectivity via ListBuckets up front - S3Config retains only cache-specific fields (bucket, TTL, upload tuning) - RegisterS3/NewS3 accept a ClientProvider parameter - Move minitest to s3client/s3clienttest with deterministic per-package bucket names derived from runtime caller inspection, cleaning stale objects up front and via t.Cleanup Example config: ```hcl s3 { endpoint = "s3.amazonaws.com" region = "us-west-2" use-ssl = true skip-ssl-verify = false } cache s3 { bucket = "my-cache-bucket" max-ttl = "1h" upload-concurrency = 4 upload-part-size-mb = 16 } ``` Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull S3 connection config (endpoint, region, SSL settings) and minio
client construction out of the S3 cache backend into a new s3client
package, following the same pattern as gitclone.Config/ManagerProvider.
bucket names derived from runtime caller inspection, cleaning stale
objects up front and via t.Cleanup
Example config: